My preference is if a call can't fit on one line, then each param should be on
a separate line. Otherwise long function calls can be hard to read and it is
easier to maintain consistent spacing. Overall, I supposes it just depends if
you prefer density or spacing.
Brad
Here's another style thing we should discuss... I'm glad you wrapped
the too-long line, but I'd really prefer to keep the number of lines
to a reasonable minimum, which means just splitting this call across
two lines instead of three. I've seen other places (for example,
immediately below) where you've added new calls with lots of params
and put each argument on a separate line, so I know that's your
preference, but it can have a seriously negative impact on the density
of code you can fit on a screen.
> + g_system_ptr->getProfiler()->profileTransition("Seq",
> + m_version,
> + Address(request.paddr),
> + "",
> + "SC Fail",
> + "",
> +
> RubyRequestType_to_string(request.type));
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
