----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/15/#review1 -----------------------------------------------------------
src/arch/trips/SConscript <http://reviews.m5sim.org/r/15/#comment1> Your (either you personally or your institution) copyright should be added to the files. In the cases where the file is completely re-written, it's unlikely that the Michigan copyright should remain. src/arch/trips/constants.hh <http://reviews.m5sim.org/r/15/#comment2> You should add yourself as the author of this file. src/arch/trips/faults.hh <http://reviews.m5sim.org/r/15/#comment3> If you're only made a minor change, or search and replace on a file it's fine to leave the original authors, however if you have made significant changes you should add your name to the Authors list. It's treated as a list of people who know what the file should do and are responsible for it. In a case where you have almost completely re-written the file, it's also acceptable to remove the authors. src/arch/trips/faults.cc <http://reviews.m5sim.org/r/15/#comment4> Does TRIPS actually have a vector number (e.g. in full system), or is this just an artifact of starting with SPARC or some other ISA? If not it should probably be removed. src/arch/trips/isa.hh <http://reviews.m5sim.org/r/15/#comment5> These comments would be better as Doxygen comments. e.g. /** floating point condition codes */ Doxygen picks up the /** and generates the documentation at http://www.m5sim.org/docs from it. src/arch/trips/isa.hh <http://reviews.m5sim.org/r/15/#comment6> //Fix me is rarely helpful, it's much better to describe what is broken. src/arch/trips/isa/base.isa <http://reviews.m5sim.org/r/15/#comment17> the spaces around ( ) with the if isn't within the m5 stytle guidlines src/arch/trips/isa_traits.hh <http://reviews.m5sim.org/r/15/#comment7> Again doxygen comments would be prefered src/arch/trips/isa_traits.hh <http://reviews.m5sim.org/r/15/#comment8> These are all artifacts of Alpha and probably should just be removed. src/arch/trips/isa_traits.hh <http://reviews.m5sim.org/r/15/#comment9> Name with these src/arch/trips/isa_traits.hh <http://reviews.m5sim.org/r/15/#comment10> These comments are wrong src/arch/trips/linux/process.cc <http://reviews.m5sim.org/r/15/#comment18> It looks like these came from Alpha and were slightly changed. If there is an official list of syscall numbers (maybe in the linux port for TRIPS), you should use those instead. src/arch/trips/linux/threadinfo.hh <http://reviews.m5sim.org/r/15/#comment19> This is also full system alpha cruft src/arch/trips/locked_mem.hh <http://reviews.m5sim.org/r/15/#comment11> Does TRIPS have a locked memory access? If not, does this file need to exist? src/arch/trips/pagetable.hh <http://reviews.m5sim.org/r/15/#comment12> There is a lot of dead code in here from Alpha... it should really be removed. src/arch/trips/pagetable.hh <http://reviews.m5sim.org/r/15/#comment13> This is really the only needed code for an SE mode TLB src/arch/trips/predecoder.hh <http://reviews.m5sim.org/r/15/#comment14> This is more cruft from Alpha that should go away src/arch/trips/stacktrace.cc <http://reviews.m5sim.org/r/15/#comment15> This is all Alpha specific full system code that should be removed. src/arch/trips/vtophys.cc <http://reviews.m5sim.org/r/15/#comment16> This il all Alpha cruft as well. - Ali On 2010-04-28 18:35:30, Gou Pengfei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/15/ > ----------------------------------------------------------- > > (Updated 2010-04-28 18:35:30) > > > Review request for Default, Ali Saidi and Nathan Binkert. > > > Summary > ------- > > This is files related to support TRIPS. Something is different in the *.isa > files due to the explicitly encoding of dependence of TRIPS ISA. Combined > with the changes in isa_parser.py, it looks OK to support TRIPS ISA. > > > Diffs > ----- > > src/arch/trips/SConscript PRE-CREATION > src/arch/trips/SConsopts PRE-CREATION > src/arch/trips/TripsTLB.py PRE-CREATION > src/arch/trips/constants.hh PRE-CREATION > src/arch/trips/faults.hh PRE-CREATION > src/arch/trips/faults.cc PRE-CREATION > src/arch/trips/isa.hh PRE-CREATION > src/arch/trips/isa.cc PRE-CREATION > src/arch/trips/isa/base.isa PRE-CREATION > src/arch/trips/isa/bitfields.isa PRE-CREATION > src/arch/trips/isa/decoder.isa PRE-CREATION > src/arch/trips/isa/formats/b.isa PRE-CREATION > src/arch/trips/isa/formats/basic.isa PRE-CREATION > src/arch/trips/isa/formats/c.isa PRE-CREATION > src/arch/trips/isa/formats/formats.isa PRE-CREATION > src/arch/trips/isa/formats/g.isa PRE-CREATION > src/arch/trips/isa/formats/i.isa PRE-CREATION > src/arch/trips/isa/formats/ls.isa PRE-CREATION > src/arch/trips/isa/formats/m.isa PRE-CREATION > src/arch/trips/isa/formats/unknown.isa PRE-CREATION > src/arch/trips/isa/formats/wr.isa PRE-CREATION > src/arch/trips/isa/includes.isa PRE-CREATION > src/arch/trips/isa/main.isa PRE-CREATION > src/arch/trips/isa/operands.isa PRE-CREATION > src/arch/trips/isa_traits.hh PRE-CREATION > src/arch/trips/linux/linux.hh PRE-CREATION > src/arch/trips/linux/linux.cc PRE-CREATION > src/arch/trips/linux/process.hh PRE-CREATION > src/arch/trips/linux/process.cc PRE-CREATION > src/arch/trips/linux/system.hh PRE-CREATION > src/arch/trips/linux/system.cc PRE-CREATION > src/arch/trips/linux/threadinfo.hh PRE-CREATION > src/arch/trips/locked_mem.hh PRE-CREATION > src/arch/trips/microcode_rom.hh PRE-CREATION > src/arch/trips/pagetable.hh PRE-CREATION > src/arch/trips/pagetable.cc PRE-CREATION > src/arch/trips/predecoder.hh PRE-CREATION > src/arch/trips/process.hh PRE-CREATION > src/arch/trips/process.cc PRE-CREATION > src/arch/trips/registers.hh PRE-CREATION > src/arch/trips/regredir.hh PRE-CREATION > src/arch/trips/regredir.cc PRE-CREATION > src/arch/trips/remote_gdb.hh PRE-CREATION > src/arch/trips/stacktrace.hh PRE-CREATION > src/arch/trips/stacktrace.cc PRE-CREATION > src/arch/trips/tlb.hh PRE-CREATION > src/arch/trips/tlb.cc PRE-CREATION > src/arch/trips/types.hh PRE-CREATION > src/arch/trips/utility.hh PRE-CREATION > src/arch/trips/utility.cc PRE-CREATION > src/arch/trips/vtophys.hh PRE-CREATION > src/arch/trips/vtophys.cc PRE-CREATION > > Diff: http://reviews.m5sim.org/r/15/diff > > > Testing > ------- > > Can perfectly run binaries generated by TRIPS toolchain. > > > Thanks, > > Gou > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
