----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/15/#review3 -----------------------------------------------------------
This is also a first pass review. I focused only on the ISA description files since Ali looked at the other ones. I'll want to look at those too in a later iteration. These files all need to be brought in line with the M5 style guidelines. src/arch/trips/isa/base.isa <http://reviews.m5sim.org/r/15/#comment30> Since this class definition doesn't really use any features of the isa parser, it would be better to move it out into regular C++. Things in the isa description inherently have one extra layer of stuff to figure out, making it harder to understand what's going on. src/arch/trips/isa/decoder.isa <http://reviews.m5sim.org/r/15/#comment31> The indentation in this file is off. Ali's comments about style apply here too. src/arch/trips/isa/decoder.isa <http://reviews.m5sim.org/r/15/#comment32> This line (and many others) is way too long. You get 80 characters, although Nate would only give you 79 (or 78? I forget). src/arch/trips/isa/formats/b.isa <http://reviews.m5sim.org/r/15/#comment33> The same as before, these hard coded class definitions should be outside the isa description. - Gabe On 2010-04-28 18:35:30, Gou Pengfei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/15/ > ----------------------------------------------------------- > > (Updated 2010-04-28 18:35:30) > > > Review request for Default, Ali Saidi and Nathan Binkert. > > > Summary > ------- > > This is files related to support TRIPS. Something is different in the *.isa > files due to the explicitly encoding of dependence of TRIPS ISA. Combined > with the changes in isa_parser.py, it looks OK to support TRIPS ISA. > > > Diffs > ----- > > src/arch/trips/SConscript PRE-CREATION > src/arch/trips/SConsopts PRE-CREATION > src/arch/trips/TripsTLB.py PRE-CREATION > src/arch/trips/constants.hh PRE-CREATION > src/arch/trips/faults.hh PRE-CREATION > src/arch/trips/faults.cc PRE-CREATION > src/arch/trips/isa.hh PRE-CREATION > src/arch/trips/isa.cc PRE-CREATION > src/arch/trips/isa/base.isa PRE-CREATION > src/arch/trips/isa/bitfields.isa PRE-CREATION > src/arch/trips/isa/decoder.isa PRE-CREATION > src/arch/trips/isa/formats/b.isa PRE-CREATION > src/arch/trips/isa/formats/basic.isa PRE-CREATION > src/arch/trips/isa/formats/c.isa PRE-CREATION > src/arch/trips/isa/formats/formats.isa PRE-CREATION > src/arch/trips/isa/formats/g.isa PRE-CREATION > src/arch/trips/isa/formats/i.isa PRE-CREATION > src/arch/trips/isa/formats/ls.isa PRE-CREATION > src/arch/trips/isa/formats/m.isa PRE-CREATION > src/arch/trips/isa/formats/unknown.isa PRE-CREATION > src/arch/trips/isa/formats/wr.isa PRE-CREATION > src/arch/trips/isa/includes.isa PRE-CREATION > src/arch/trips/isa/main.isa PRE-CREATION > src/arch/trips/isa/operands.isa PRE-CREATION > src/arch/trips/isa_traits.hh PRE-CREATION > src/arch/trips/linux/linux.hh PRE-CREATION > src/arch/trips/linux/linux.cc PRE-CREATION > src/arch/trips/linux/process.hh PRE-CREATION > src/arch/trips/linux/process.cc PRE-CREATION > src/arch/trips/linux/system.hh PRE-CREATION > src/arch/trips/linux/system.cc PRE-CREATION > src/arch/trips/linux/threadinfo.hh PRE-CREATION > src/arch/trips/locked_mem.hh PRE-CREATION > src/arch/trips/microcode_rom.hh PRE-CREATION > src/arch/trips/pagetable.hh PRE-CREATION > src/arch/trips/pagetable.cc PRE-CREATION > src/arch/trips/predecoder.hh PRE-CREATION > src/arch/trips/process.hh PRE-CREATION > src/arch/trips/process.cc PRE-CREATION > src/arch/trips/registers.hh PRE-CREATION > src/arch/trips/regredir.hh PRE-CREATION > src/arch/trips/regredir.cc PRE-CREATION > src/arch/trips/remote_gdb.hh PRE-CREATION > src/arch/trips/stacktrace.hh PRE-CREATION > src/arch/trips/stacktrace.cc PRE-CREATION > src/arch/trips/tlb.hh PRE-CREATION > src/arch/trips/tlb.cc PRE-CREATION > src/arch/trips/types.hh PRE-CREATION > src/arch/trips/utility.hh PRE-CREATION > src/arch/trips/utility.cc PRE-CREATION > src/arch/trips/vtophys.hh PRE-CREATION > src/arch/trips/vtophys.cc PRE-CREATION > > Diff: http://reviews.m5sim.org/r/15/diff > > > Testing > ------- > > Can perfectly run binaries generated by TRIPS toolchain. > > > Thanks, > > Gou > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
