> 1. In several places we are using dynamic_cast. The patch under consideration > moves some of these to safe_cast and retains dynamic_cast at other places. > Should we not use safe_cast in all places? This would avoid the checks that > dynamic_cast carries out when not running the debug version.
I used safe cast where the original code used dynamic_cast + assert. I used dynamic_cast elsewhere. I'll admit that there are several places where I probably should have used safe_cast since the return value of dynamic_cast wasn't checked anyway. I'll fix them. > 2. In the file src/mem/ruby/system/DMASequencer.cc, we use > msg->getType/LineAddress/PhysicalAddress() = ; > Should we not call the set() function instead? Both we will have the same > effect but set() is more readable. Probably, but I don't want to confuse this changeset with unrelated changes. I'd encourage you to fix things like this yourself once I get my commits done. Thanks for the review! Keep 'em coming. Nate _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
