-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/54/#review105
-----------------------------------------------------------



src/cpu/o3/lsq_unit.hh
<http://reviews.m5sim.org/r/54/#comment247>

    Is it possible for sreqLow to be non-null and TheISA::HasUnalignedMemAcc 
-not- to be true? In that instance, wouldn't this still be a split access? Or 
does the code not shown in this diff make that not work?
    
    If this is just to make it more obvious what sort of condition your 
checking for a comment would be better, or if it's a sanity check sort of thing 
an assert.


- Gabe


On 2010-07-09 18:20:19, Timothy Jones wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/54/
> -----------------------------------------------------------
> 
> (Updated 2010-07-09 18:20:19)
> 
> 
> Review request for Default.
> 
> 
> Summary
> -------
> 
> O3CPU: Fix a bug where stores in the cpu where never marked as split.
> 
> 
> Diffs
> -----
> 
>   src/cpu/o3/lsq_unit.hh 249f174e6f37 
> 
> Diff: http://reviews.m5sim.org/r/54/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Timothy
> 
>

_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to