----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/68/#review112 -----------------------------------------------------------
Looks fine to me... anyone else? - Ali On 2010-07-29 07:59:26, Ioannis Ilkos wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/68/ > ----------------------------------------------------------- > > (Updated 2010-07-29 07:59:26) > > > Review request for Default. > > > Summary > ------- > > This is a patch fixing the ThreadContext suspension / activation described in > http://www.mail-archive.com/[email protected]/msg07307.html and implementing > the nanosleep() syscall (albeit without the signal-relevant parts) for > AlphaLinux. > > Changes in O3: > - The tick scheduling was removed from activateContext() and moved into > activateThread(). It seems more natural since activateContext() either calls > activateThread() or schedules it. In the case of scheduling there is no need > to schedule ticks prematurely. > - suspendContext() and haltContext() check the number of active threads > before setting CPU _status to Idle. > > > Diffs > ----- > > src/arch/alpha/linux/linux.hh b28e7286990c > src/arch/alpha/linux/process.cc b28e7286990c > src/cpu/o3/cpu.cc b28e7286990c > src/sim/syscall_emul.hh b28e7286990c > > Diff: http://reviews.m5sim.org/r/68/diff > > > Testing > ------- > > > Thanks, > > Ioannis > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
