It's fine with me, but we'd need to be really careful the semantics
(64 bit vs. 32 bit operands, flags, etc.) are translated correctly. If
a syscall isn't there at all it's obvious why it's not going to work,
but if it is there and slightly wrong it'd be a lot harder to figure
out what's wrong.
Gabe
Quoting Timothy Jones <[email protected]>:
On 2010-07-29 08:46:47, Steve Reinhardt wrote:
> src/arch/alpha/linux/process.cc, line 470
> <http://reviews.m5sim.org/r/68/diff/1/?file=834#file834line470>
>
> This is a broader question (not just for Ioannis): does it
make sense to proactively add this to the syscall tables for the
other ISAs too? I don't see anything ISA-specific here.
I would be in favour of doing that, yes.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/68/#review115
-----------------------------------------------------------
On 2010-07-29 07:59:26, Ioannis Ilkos wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/68/
-----------------------------------------------------------
(Updated 2010-07-29 07:59:26)
Review request for Default.
Summary
-------
This is a patch fixing the ThreadContext suspension / activation
described in
http://www.mail-archive.com/[email protected]/msg07307.html and
implementing the nanosleep() syscall (albeit without the
signal-relevant parts) for AlphaLinux.
Changes in O3:
- The tick scheduling was removed from activateContext() and moved
into activateThread(). It seems more natural since
activateContext() either calls activateThread() or schedules it. In
the case of scheduling there is no need to schedule ticks
prematurely.
- suspendContext() and haltContext() check the number of active
threads before setting CPU _status to Idle.
Diffs
-----
src/arch/alpha/linux/linux.hh b28e7286990c
src/arch/alpha/linux/process.cc b28e7286990c
src/cpu/o3/cpu.cc b28e7286990c
src/sim/syscall_emul.hh b28e7286990c
Diff: http://reviews.m5sim.org/r/68/diff
Testing
-------
Thanks,
Ioannis
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
