----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/27/#review123 -----------------------------------------------------------
src/python/m5/SimObject.py <http://reviews.m5sim.org/r/27/#comment259> Seems like you could have a lot less code if you had a sorted=False parameter to iterChildren. You could also rely on people just calling (or implement it by doing) sorted(iterChildren(), key=lambda c: c.name) src/python/m5/simulate.py <http://reviews.m5sim.org/r/27/#comment261> Why exactly is this more deterministic? It seems that if unproxying can be non-deterministic, we should flag that as an error, no? src/python/m5/simulate.py <http://reviews.m5sim.org/r/27/#comment262> I'd say for easier diffing. src/python/swig/sim_object.i <http://reviews.m5sim.org/r/27/#comment263> How far are we from just doing a %include of sim_object.hh? src/sim/sim_object.cc <http://reviews.m5sim.org/r/27/#comment264> I like this! - Nathan On 2010-07-29 21:42:28, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/27/ > ----------------------------------------------------------- > > (Updated 2010-07-29 21:42:28) > > > Review request for Default. > > > Summary > ------- > > sim: move iterating over SimObjects into Python. > > > Diffs > ----- > > src/python/m5/SimObject.py b28e7286990c > src/python/m5/core.py b28e7286990c > src/python/m5/simulate.py b28e7286990c > src/python/m5/stats.py b28e7286990c > src/python/swig/core.i b28e7286990c > src/python/swig/pyobject.hh b28e7286990c > src/python/swig/sim_object.i b28e7286990c > src/sim/sim_object.hh b28e7286990c > src/sim/sim_object.cc b28e7286990c > > Diff: http://reviews.m5sim.org/r/27/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
