----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/27/#review129 -----------------------------------------------------------
src/python/m5/SimObject.py <http://reviews.m5sim.org/r/27/#comment265> I'm not sure you'd save that many LOC, but it might be a nicer interface. Also, since you cast some doubt on one of the two places it's used, forcing the caller to use sorted() doesn't seem so bad. src/python/m5/simulate.py <http://reviews.m5sim.org/r/27/#comment266> Good point... I just copied the logic and the comment from SimObject.py line 684. I agree it seems unnecessary. src/python/m5/simulate.py <http://reviews.m5sim.org/r/27/#comment267> Determinism across minor code changes, so basically the same thing... but yeah. src/python/swig/sim_object.i <http://reviews.m5sim.org/r/27/#comment268> Beats me, it didn't cross my mind... - Steve On 2010-07-29 21:42:28, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/27/ > ----------------------------------------------------------- > > (Updated 2010-07-29 21:42:28) > > > Review request for Default. > > > Summary > ------- > > sim: move iterating over SimObjects into Python. > > > Diffs > ----- > > src/python/m5/SimObject.py b28e7286990c > src/python/m5/core.py b28e7286990c > src/python/m5/simulate.py b28e7286990c > src/python/m5/stats.py b28e7286990c > src/python/swig/core.i b28e7286990c > src/python/swig/pyobject.hh b28e7286990c > src/python/swig/sim_object.i b28e7286990c > src/sim/sim_object.hh b28e7286990c > src/sim/sim_object.cc b28e7286990c > > Diff: http://reviews.m5sim.org/r/27/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
