----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/92/#review140 -----------------------------------------------------------
src/cpu/memtest/MemTest.py <http://reviews.m5sim.org/r/92/#comment279> is_dma seems like a strange name. Something like use_dma or issue_dmas might be better. Also, everything else is a percentage. How often do you issue DMAs here? I think you should either specify it somewhere in a comment or make it a percentage to begin with. Or is it that all requests are DMAs? Don't you want to interleave them? src/cpu/memtest/memtest.cc <http://reviews.m5sim.org/r/92/#comment280> This seems like an unrelated change. - Nathan On 2010-08-05 21:44:17, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/92/ > ----------------------------------------------------------- > > (Updated 2010-08-05 21:44:17) > > > Review request for Default. > > > Summary > ------- > > memtest: Memtester support for DMA > > This patch adds DMA testing to the Memtester and is inherits many changes from > Polina's old tester_dma_extension patch. > > > Diffs > ----- > > configs/example/memtest-ruby.py a75564db03c3 > configs/ruby/MESI_CMP_directory.py PRE-CREATION > configs/ruby/MI_example.py PRE-CREATION > configs/ruby/MOESI_CMP_directory.py PRE-CREATION > configs/ruby/MOESI_CMP_token.py PRE-CREATION > configs/ruby/MOESI_hammer.py PRE-CREATION > src/cpu/memtest/MemTest.py a75564db03c3 > src/cpu/memtest/memtest.hh a75564db03c3 > src/cpu/memtest/memtest.cc a75564db03c3 > src/mem/ruby/system/DMASequencer.cc a75564db03c3 > src/mem/ruby/system/SConscript a75564db03c3 > > Diff: http://reviews.m5sim.org/r/92/diff > > > Testing > ------- > > > Thanks, > > Brad > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
