> On 2010-08-11 19:43:23, Nathan Binkert wrote: > > It looks like you removed a whole lot of features in this diff. Why did > > you do this? Can you explain it in the commit message?
Ruby doesn't work in atomic mode. Therefore it doesn't make sense to have atomic mode options in this file. Sure, I'll update the commit message. > On 2010-08-11 19:43:23, Nathan Binkert wrote: > > configs/example/memtest-ruby.py, line 70 > > <http://reviews.m5sim.org/r/92/diff/2/?file=1648#file1648line70> > > > > What does this mean? Can you add some help? Similar to --num-cpus, this is the number of dma testers. I added a help message. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/92/#review162 ----------------------------------------------------------- On 2010-08-11 14:36:07, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/92/ > ----------------------------------------------------------- > > (Updated 2010-08-11 14:36:07) > > > Review request for Default. > > > Summary > ------- > > memtest: Memtester support for DMA > > This patch adds DMA testing to the Memtester and is inherits many changes from > Polina's old tester_dma_extension patch. > > > Diffs > ----- > > configs/example/memtest-ruby.py a75564db03c3 > configs/ruby/MESI_CMP_directory.py PRE-CREATION > configs/ruby/MI_example.py PRE-CREATION > configs/ruby/MOESI_CMP_directory.py PRE-CREATION > configs/ruby/MOESI_CMP_token.py PRE-CREATION > configs/ruby/MOESI_hammer.py PRE-CREATION > src/cpu/memtest/MemTest.py a75564db03c3 > src/cpu/memtest/memtest.hh a75564db03c3 > src/cpu/memtest/memtest.cc a75564db03c3 > src/mem/ruby/system/DMASequencer.cc a75564db03c3 > src/mem/ruby/system/SConscript a75564db03c3 > > Diff: http://reviews.m5sim.org/r/92/diff > > > Testing > ------- > > > Thanks, > > Brad > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
