----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/193/#review191 -----------------------------------------------------------
src/mem/cache/tags/iic.hh <http://reviews.m5sim.org/r/193/#comment332> It's best to avoid whitespace only changes, I suppose unless you're fixing a style issue. src/mem/request.hh <http://reviews.m5sim.org/r/193/#comment331> This name and comment is too ARM centric. A better name might be CLEAR_LOCK. - Gabe On 2010-08-13 10:16:38, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/193/ > ----------------------------------------------------------- > > (Updated 2010-08-13 10:16:38) > > > Review request for Default. > > > Summary > ------- > > MEM: Make CLREX a first class request operation and clear locks in caches > when it in received > > > Diffs > ----- > > src/arch/arm/isa/insts/misc.isa 3c48b2b3cb83 > src/arch/arm/isa/templates/misc.isa 3c48b2b3cb83 > src/arch/arm/tlb.hh 3c48b2b3cb83 > src/arch/arm/tlb.cc 3c48b2b3cb83 > src/mem/cache/cache_impl.hh 3c48b2b3cb83 > src/mem/cache/tags/base.hh 3c48b2b3cb83 > src/mem/cache/tags/fa_lru.hh 3c48b2b3cb83 > src/mem/cache/tags/fa_lru.cc 3c48b2b3cb83 > src/mem/cache/tags/iic.hh 3c48b2b3cb83 > src/mem/cache/tags/iic.cc 3c48b2b3cb83 > src/mem/cache/tags/lru.hh 3c48b2b3cb83 > src/mem/cache/tags/lru.cc 3c48b2b3cb83 > src/mem/request.hh 3c48b2b3cb83 > > Diff: http://reviews.m5sim.org/r/193/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
