> On 2010-08-13 23:45:23, Gabe Black wrote: > > src/base/loader/elf_object.cc, line 378 > > <http://reviews.m5sim.org/r/169/diff/1/?file=1854#file1854line378> > > > > Are all symbols 100% guaranteed to be one character or longer? Is > > excluding symbols with "$" a universal behavior? > > > > I honestly don't know the answers to those questions, but they make me > > a little nervous.
Well, the previous code ha that problem as well, but I've changed to to verify that elf_strptr didn't return null. Symbols beginning with $ are normally internally compiler/assembler generated and just turn the output into a but of $a+XXX instead of something meaningful, so it should be fine to ignore them. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/169/#review179 ----------------------------------------------------------- On 2010-08-13 10:08:02, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/169/ > ----------------------------------------------------------- > > (Updated 2010-08-13 10:08:02) > > > Review request for Default. > > > Summary > ------- > > Loader: Don't insert symbols into the symbol table that begin wiht '$'. > > > Diffs > ----- > > src/base/loader/elf_object.cc 3c48b2b3cb83 > > Diff: http://reviews.m5sim.org/r/169/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
