----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/169/#review179 -----------------------------------------------------------
src/base/loader/elf_object.cc <http://reviews.m5sim.org/r/169/#comment321> Are all symbols 100% guaranteed to be one character or longer? Is excluding symbols with "$" a universal behavior? I honestly don't know the answers to those questions, but they make me a little nervous. - Gabe On 2010-08-13 10:08:02, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/169/ > ----------------------------------------------------------- > > (Updated 2010-08-13 10:08:02) > > > Review request for Default. > > > Summary > ------- > > Loader: Don't insert symbols into the symbol table that begin wiht '$'. > > > Diffs > ----- > > src/base/loader/elf_object.cc 3c48b2b3cb83 > > Diff: http://reviews.m5sim.org/r/169/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
