> On 2010-08-14 00:03:01, Gabe Black wrote: > > src/arch/arm/faults.hh, line 221 > > <http://reviews.m5sim.org/r/176/diff/1/?file=1865#file1865line221> > > > > What made this necessary? Why does non-ARM specific code need to > > generate resets through machine check faults?
The O3 cpu generates a fault when something that shouldn't happen does happen to make sure it doesn't reach past commit and is instead squashed. > On 2010-08-14 00:03:01, Gabe Black wrote: > > src/arch/arm/faults.hh, line 224 > > <http://reviews.m5sim.org/r/176/diff/1/?file=1865#file1865line224> > > > > Don't comment out code, delete it. Done. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/176/#review184 ----------------------------------------------------------- On 2010-08-13 10:12:22, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/176/ > ----------------------------------------------------------- > > (Updated 2010-08-13 10:12:22) > > > Review request for Default. > > > Summary > ------- > > ARM: adding genMachineCheckFault() stub for ARM that doesn't panic > > > Diffs > ----- > > src/arch/arm/faults.hh 3c48b2b3cb83 > > Diff: http://reviews.m5sim.org/r/176/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
