----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/158/#review229 -----------------------------------------------------------
Why exactly did you make this change. The FifoBuffer class limits (I think) the number of entries allowed and you removed that restriction. Are you sure you want to do that? src/arch/arm/table_walker.hh <http://reviews.m5sim.org/r/158/#comment379> We put the standard includes above the rest in sorted order. - Nathan On 2010-08-13 09:41:33, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/158/ > ----------------------------------------------------------- > > (Updated 2010-08-13 09:41:33) > > > Review request for Default. > > > Summary > ------- > > ARM: Use a stl queue for the table walker state > > > Diffs > ----- > > src/arch/arm/table_walker.hh 3c48b2b3cb83 > src/arch/arm/table_walker.cc 3c48b2b3cb83 > > Diff: http://reviews.m5sim.org/r/158/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
