----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/189/#review250 -----------------------------------------------------------
src/arch/arm/table_walker.hh <http://reviews.m5sim.org/r/189/#comment394> As you know, we generally don't like magic bits randomly placed. Is there no more centralized location that you can spell out what all of the bits are? (I can accept NO as an answer. - Nathan On 2010-08-13 10:14:37, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/189/ > ----------------------------------------------------------- > > (Updated 2010-08-13 10:14:37) > > > Review request for Default. > > > Summary > ------- > > ARM: Fix Uncachable TLB requests and decoding of xn bit > > > Diffs > ----- > > src/arch/arm/table_walker.hh 3c48b2b3cb83 > src/arch/arm/table_walker.cc 3c48b2b3cb83 > src/arch/arm/tlb.cc 3c48b2b3cb83 > > Diff: http://reviews.m5sim.org/r/189/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
