> On 2010-08-19 10:12:11, Ali Saidi wrote: > > src/arch/arm/table_walker.hh, line 109 > > <http://reviews.m5sim.org/r/189/diff/1/?file=1902#file1902line109> > > > > The bit is described by the function name that grabs it. I don't see > > much benefit to having an enum of bit descriptions and then having bool > > xn() {const return bits(data, xnBit); > > } > > This becomes more difficult for the functions that grab bits from three > > different places. > > > > Honenstly i don't think it adds anything to clarity and we're 100% sure > > these are right now and they won't need to change.
Ok, if this is the only place that they're used, I'm fine with it. - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/189/#review260 ----------------------------------------------------------- On 2010-08-13 10:14:37, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/189/ > ----------------------------------------------------------- > > (Updated 2010-08-13 10:14:37) > > > Review request for Default. > > > Summary > ------- > > ARM: Fix Uncachable TLB requests and decoding of xn bit > > > Diffs > ----- > > src/arch/arm/table_walker.hh 3c48b2b3cb83 > src/arch/arm/table_walker.cc 3c48b2b3cb83 > src/arch/arm/tlb.cc 3c48b2b3cb83 > > Diff: http://reviews.m5sim.org/r/189/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
