----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/211/#review290 -----------------------------------------------------------
I see nothing obviously wrong with this. - Nathan On 2010-08-22 18:53:51, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/211/ > ----------------------------------------------------------- > > (Updated 2010-08-22 18:53:51) > > > Review request for Default. > > > Summary > ------- > > X86: Get rid of the flagless microop constructor. > > This will reduce clutter in the source and hopefully speed up compilation. > > > Diffs > ----- > > src/arch/x86/isa/formats/string.isa 405f840c4ae1 > src/arch/x86/isa/microops/debug.isa 405f840c4ae1 > src/arch/x86/isa/microops/fpop.isa 405f840c4ae1 > src/arch/x86/isa/microops/ldstop.isa 405f840c4ae1 > src/arch/x86/isa/microops/limmop.isa 405f840c4ae1 > src/arch/x86/isa/microops/mediaop.isa 405f840c4ae1 > src/arch/x86/isa/microops/regop.isa 405f840c4ae1 > src/arch/x86/isa/microops/seqop.isa 405f840c4ae1 > src/arch/x86/isa/microops/specop.isa 405f840c4ae1 > > Diff: http://reviews.m5sim.org/r/211/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
