Nate, the idea behind this set of changes is to do away with the debug
support (including DEBUG_EXPR) provided by Ruby. Deciding whether given
volume of debug output is too verbose or not will vary from situation to
situation. Since M5 does not have a verbosity level, it is better not to
have it in Ruby either. It should be left to users of M5 what they feel is
verbose or not.
Brad, the change is pretty minor (only the processing of DPRINTF() call in
FuncCallExprAST.py has changed). As I mentioned before, whatever trace
flag is supplied, RubySlicc is what SLICC would output. The reason to
carry out the change is that using DPRINTF() in two different forms would
have been confusing for the users. Note that even Steve thought that
DPRINTF() calls are broken.
--
Nilay
On Tue, 26 Oct 2010, nathan binkert wrote:
GEMS has supported multiple filter strings ever since I can remember and one
could have added the ability to use multiple filter strings to .sm debug
statements in the past, but there has never been the need to. It just seems
redundant to explicitly specify the debug string and the .sm files are already
quite verbose.
In my mind, we are needlessly adding a feature to the .sm files that we don't
need and we're just further cluttering the .sm files.
My objection is based on the fact that there are several commented out
DEBUG_EXPR statements. That usually happens when the output is too
verbose and as a result, people comment out the lines. It would be
better to instead have another flag for a different verbosity level.
If you remove that ability, then people will again comment out lines.
Also, there is a priority parameter to DEBUG_EXPR. Was that a
verbosity level? Did we want to get rid of that?
I have to say that you're removing a useful feature just because it
saves 7 characters. Just because you never used multiple flags
doesn't mean that nobody else would. Adding more flags means that you
can put in a log more debugging statements.
Nate
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
