----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/296/#review449 -----------------------------------------------------------
Ship it! It would be nice not to propagate the "convoluted way" this is done, aka the hack, but in this context it's reasonable. - Gabe On 2010-11-08 15:35:33, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/296/ > ----------------------------------------------------------- > > (Updated 2010-11-08 15:35:33) > > > Review request for Default. > > > Summary > ------- > > O3: prevent a squash when completeAcc() modifies misc reg through TC. > > This happens on ARM instructions when they update the IT state bits. > Code and associated comment was copied from execute() and initiateAcc() > methods > > > Diffs > ----- > > src/cpu/o3/dyn_inst_impl.hh f61e079ad05e > > Diff: http://reviews.m5sim.org/r/296/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
