----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/298/#review473 -----------------------------------------------------------
So it looks like whether you call setMiscReg() or setMiscRegNoEffect() then you buffer the update and call setMiscReg() later... i.e., even if you called setMiscRegNoEffect() originally you end up calling setMiscReg() at commit. Are there ever cases where we call setMiscRegNoEffect() from an instruction? I thought it was strictly for things like system initialization and restoring from checkpoints anyway... maybe we don't need it in the ExecContext interface. Also, I see that these predate your change, but why do we need both the setMiscReg() calls and the setMiscRegOperand() calls? Is one of them deprecated? Can we take this opportunity to update the comments to distinguish them? We shouldn't have two different functions for which the descriptive comment is completely identical IMO. - Steve On 2010-11-08 15:46:52, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/298/ > ----------------------------------------------------------- > > (Updated 2010-11-08 15:46:52) > > > Review request for Default. > > > Summary > ------- > > O3: Make all instructions that write a misc register not perform the write > until commit. > > ARM Instructions updating cumulative flags (ARM FP exceptions and saturation > flags) are not serialized. > > Added aliases for ARM FP exceptions and saturation flags in FPSCR. > > > Diffs > ----- > > src/arch/arm/isa.cc f61e079ad05e > src/arch/arm/isa/insts/fp.isa f61e079ad05e > src/arch/arm/isa/insts/neon.isa f61e079ad05e > src/arch/arm/isa/operands.isa f61e079ad05e > src/arch/arm/miscregs.hh f61e079ad05e > src/cpu/o3/commit_impl.hh f61e079ad05e > src/cpu/o3/dyn_inst.hh f61e079ad05e > src/cpu/o3/dyn_inst_impl.hh f61e079ad05e > > Diff: http://reviews.m5sim.org/r/298/diff > > > Testing > ------- > > > Thanks, > > Ali > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
