-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/305/#review477
-----------------------------------------------------------

Ship it!


Looks ok. You could put the sp index into a temporary variable and shorten up 
the wb declaration code, but it's ok as is too.

- Gabe


On 2010-11-11 16:13:47, Ali Saidi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/305/
> -----------------------------------------------------------
> 
> (Updated 2010-11-11 16:13:47)
> 
> 
> Review request for Default.
> 
> 
> Summary
> -------
> 
> ARM: Fix SRS instruction to micro-code memory operation and register update.
> 
> Previously the SRS instruction attempted to writeback in initiateAcc() which
> worked until a recent change, but was incorrect.
> 
> 
> Diffs
> -----
> 
>   src/arch/arm/isa/insts/str.isa 3155a9ccb66b 
> 
> Diff: http://reviews.m5sim.org/r/305/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ali
> 
>

_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to