1) Ali and I discussed some tweaks the other day. TRACEING should be TRACING, and MAKEISA would be better as CFG ISA if I remember right. Otherwise I'm happy with the strings. 2) Now that you mention it, left justified might be better. I don't have a really string opinion. I still don't really like the []s. 3) I don't care hugely, but my gut is that the space will make things more readable. 4) When I was doing this in another context I initially wanted to be consistent, but sometimes one thing makes sense and other times something else is better.
Gabe On 11/12/10 11:55, nathan binkert wrote: > I lost the changeset comment on this one. I'm happy to commit this > now, but there are a couple of tweaks we could make: > > 1) Are we happy with the strings now? (I am, and we could in the > future change them without any real issues) > 2) Do we like having it right justified? (It looks funny now that the > strings are longer, but I don't care that much.) > 3) Is the one space indent worth it? > 4) should we show source and target? source always? target always? > or just leave it as is? > > Nate > > > On Fri, Nov 12, 2010 at 11:50 AM, Nathan Binkert <[email protected] > <mailto:[email protected]>> wrote: > > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/299/ > > > Review request for Default. > By Ali Saidi. > > /Updated 2010-11-12 11:50:34.334284/ > > > Description (updated) > > [mq]: pretty_scons.diff > > > Diffs (updated) > > * src/arch/SConscript (f97a5f4d0879) > * src/arch/isa_parser.py (f97a5f4d0879) > * src/cpu/SConscript (f97a5f4d0879) > * src/SConscript (f97a5f4d0879) > * SConstruct (f97a5f4d0879) > > View Diff <http://reviews.m5sim.org/r/299/diff/> > > > > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
