> On 2010-12-06 15:56:33, Steve Reinhardt wrote: > > src/mem/ruby/common/Debug.hh, line 146 > > <http://reviews.m5sim.org/r/337/diff/2/?file=5442#file5442line146> > > > > What changed in these lines? I don't see any difference here. Was it > > just a whitespace thing? If so, was it intentional? > > Nilay Vaish wrote: > I had shifted the entire code that appears under the block > if(ASSERT_FLAG). For these lines, '<<' was aligned with '<<' appearing in the > line above.
I see... they used to be off by one but now they're not anymore. > On 2010-12-06 15:56:33, Steve Reinhardt wrote: > > src/mem/slicc/ast/FuncCallExprAST.py, line 168 > > <http://reviews.m5sim.org/r/337/diff/2/?file=5443#file5443line168> > > > > Is there a reason the compiler doesn't just emit "ASSERT(${{cvec[0]}})" > > here? That seems more straightforward to me, unless there's a good reason > > to do it this way. > > Nilay Vaish wrote: > I think the reason is that we would like to have the line numbers from > the .sm file. If we use ASSERT(), then the line numbers from the generated > .cc files will be put in place. That makes sense, thanks... - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/337/#review510 ----------------------------------------------------------- On 2010-12-02 20:35:31, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/337/ > ----------------------------------------------------------- > > (Updated 2010-12-02 20:35:31) > > > Review request for Default. > > > Summary > ------- > > This diff is for changing the way ASSERT is handled in Ruby. m5.fast compiles > out the assert statements by using the macro NDEBUG. Ruby uses the macro > RUBY_NO_ASSERT to do so. This macro has been removed and NDEBUG has been put > in its place. > > > Diffs > ----- > > src/mem/ruby/common/Debug.hh 42da07116e12 > src/mem/slicc/ast/FuncCallExprAST.py 42da07116e12 > > Diff: http://reviews.m5sim.org/r/337/diff > > > Testing > ------- > > I have compiled the source code with this change. The object files created > for debug version have the assert statements while those for the fast version > don't. > > > Thanks, > > Nilay > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
