----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/337/#review510 -----------------------------------------------------------
src/mem/ruby/common/Debug.hh <http://reviews.m5sim.org/r/337/#comment751> Someday we should unify m5 & Ruby assertions... basically everyone should use this macro or no one should. Don't hold up this patch on that though; I just want to throw that thought out there for consideration. src/mem/ruby/common/Debug.hh <http://reviews.m5sim.org/r/337/#comment749> What changed in these lines? I don't see any difference here. Was it just a whitespace thing? If so, was it intentional? src/mem/slicc/ast/FuncCallExprAST.py <http://reviews.m5sim.org/r/337/#comment750> Is there a reason the compiler doesn't just emit "ASSERT(${{cvec[0]}})" here? That seems more straightforward to me, unless there's a good reason to do it this way. - Steve On 2010-12-02 20:35:31, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/337/ > ----------------------------------------------------------- > > (Updated 2010-12-02 20:35:31) > > > Review request for Default. > > > Summary > ------- > > This diff is for changing the way ASSERT is handled in Ruby. m5.fast compiles > out the assert statements by using the macro NDEBUG. Ruby uses the macro > RUBY_NO_ASSERT to do so. This macro has been removed and NDEBUG has been put > in its place. > > > Diffs > ----- > > src/mem/ruby/common/Debug.hh 42da07116e12 > src/mem/slicc/ast/FuncCallExprAST.py 42da07116e12 > > Diff: http://reviews.m5sim.org/r/337/diff > > > Testing > ------- > > I have compiled the source code with this change. The object files created > for debug version have the assert statements while those for the fast version > don't. > > > Thanks, > > Nilay > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
