----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/346/#review526 -----------------------------------------------------------
Malformed commit message again. It would be nice not to lose the information in the commit message. Ideally it would pop out if the fault was invoked in SE mode, but more trivially it could be moved into a comment above the new version. src/arch/arm/isa/formats/fp.isa <http://reviews.m5sim.org/r/346/#comment782> The style of this comment looks unusual, although I don't think I can say it's wrong. I think the line with /* should at least be otherwise blank, but really // style comments would work better. Gramatically this is actually two sentences. I think the comment in general is probably not necessary since the name immValid makes it pretty clear what's going on. src/arch/arm/isa/formats/fp.isa <http://reviews.m5sim.org/r/346/#comment780> Misplaced brace src/arch/arm/isa/insts/neon.isa <http://reviews.m5sim.org/r/346/#comment784> delete, don't comment out src/arch/arm/isa/insts/neon.isa <http://reviews.m5sim.org/r/346/#comment783> delete, don't comment out - Gabe On 2010-12-06 16:14:12, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/346/ > ----------------------------------------------------------- > > (Updated 2010-12-06 16:14:12) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > The ARM decoder should not panic when decoding undefined holes in the > Architecture, as this can abort simulations when the fetch unit runs > ahead and speculatively decodes instructions that are off the execution > path or that are generated dynamically. > > > Diffs > ----- > > src/arch/arm/insts/macromem.cc 2b5fbdcbfb5d > src/arch/arm/insts/pred_inst.hh 2b5fbdcbfb5d > src/arch/arm/isa/formats/fp.isa 2b5fbdcbfb5d > src/arch/arm/isa/formats/misc.isa 2b5fbdcbfb5d > src/arch/arm/isa/insts/neon.isa 2b5fbdcbfb5d > src/arch/arm/miscregs.cc 2b5fbdcbfb5d > > Diff: http://reviews.m5sim.org/r/346/diff > > > Testing > ------- > > > Thanks, > > Ali > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
