> On 2010-12-08 23:56:50, Gabe Black wrote: > > Malformed commit message again. > > > > It would be nice not to lose the information in the commit message. Ideally > > it would pop out if the fault was invoked in SE mode, but more trivially it > > could be moved into a comment above the new version. > > Ali Saidi wrote: > Well, it didn't come out in review board, but the description is: > The ARM decoder should not panic when decoding undefined holes<newline> > rest of message. You get the the best of both worlds. This doesn't work > so well in the case of SE mode either, because te O3 CPU can still speculate > and cause the same issues. > > Fixed rest of the issued mentioned.
Woops, that should have said "not lose the information in the panics", ie that the size was invalid, something wasn't recognized, etc. It would be great if there was still a message when the fault happened and that ends the simulation (basically SE, I think), but moving the panic message into a comment at least preserves the intent if someone finds where a fault came from. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/346/#review526 ----------------------------------------------------------- On 2010-12-06 16:14:12, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/346/ > ----------------------------------------------------------- > > (Updated 2010-12-06 16:14:12) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > The ARM decoder should not panic when decoding undefined holes in the > Architecture, as this can abort simulations when the fetch unit runs > ahead and speculatively decodes instructions that are off the execution > path or that are generated dynamically. > > > Diffs > ----- > > src/arch/arm/insts/macromem.cc 2b5fbdcbfb5d > src/arch/arm/insts/pred_inst.hh 2b5fbdcbfb5d > src/arch/arm/isa/formats/fp.isa 2b5fbdcbfb5d > src/arch/arm/isa/formats/misc.isa 2b5fbdcbfb5d > src/arch/arm/isa/insts/neon.isa 2b5fbdcbfb5d > src/arch/arm/miscregs.cc 2b5fbdcbfb5d > > Diff: http://reviews.m5sim.org/r/346/diff > > > Testing > ------- > > > Thanks, > > Ali > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
