----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/355/#review550 -----------------------------------------------------------
src/python/m5/main.py <http://reviews.m5sim.org/r/355/#comment802> What is the point of passing in 2 args? so you can have them pre-parsed? Either way a comment is helpful. src/sim/init.cc <http://reviews.m5sim.org/r/355/#comment801> Here too? why do we want weak linking? So you can override it? src/sim/init.cc <http://reviews.m5sim.org/r/355/#comment800> I think this needs a comment - Ali On 2010-12-21 08:25:49, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/355/ > ----------------------------------------------------------- > > (Updated 2010-12-21 08:25:49) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > python: cleanup python code so stuff doesn't automatically happen at startup > this allows things to be overridden at startup (e.g. for tests) > > > Diffs > ----- > > src/python/m5/__init__.py 4a3bddd74f36 > src/python/m5/main.py 4a3bddd74f36 > src/python/m5/simulate.py 4a3bddd74f36 > src/sim/init.cc 4a3bddd74f36 > > Diff: http://reviews.m5sim.org/r/355/diff > > > Testing > ------- > > > Thanks, > > Nathan > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
