> On 2010-12-21 14:17:11, Gabe Black wrote: > > src/sim/init.cc, line 226 > > <http://reviews.m5sim.org/r/355/diff/1/?file=5803#file5803line226> > > > > Since this is technically a pointer, should this be NULL instead of 0?
No. They're identical. NULL is a holdover from C where it was typically #defined to (void *)0, but no longer is that the case: http://www2.research.att.com/~bs/bs_faq2.html#null - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/355/#review554 ----------------------------------------------------------- On 2010-12-21 08:25:49, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/355/ > ----------------------------------------------------------- > > (Updated 2010-12-21 08:25:49) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > python: cleanup python code so stuff doesn't automatically happen at startup > this allows things to be overridden at startup (e.g. for tests) > > > Diffs > ----- > > src/python/m5/__init__.py 4a3bddd74f36 > src/python/m5/main.py 4a3bddd74f36 > src/python/m5/simulate.py 4a3bddd74f36 > src/sim/init.cc 4a3bddd74f36 > > Diff: http://reviews.m5sim.org/r/355/diff > > > Testing > ------- > > > Thanks, > > Nathan > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
