----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/339/#review582 -----------------------------------------------------------
src/cpu/o3/iew_impl.hh <http://reviews.m5sim.org/r/339/#comment821> This comment is not relevant to a review of this code at all, but I just have to point out that this is the first place I can recall that I've seen an explicit boolean comparison that makes sense... as Brad knows, explicit equality/inequality comparisons with true/false annoy me greatly as a huge redundancy, but given that "predicated false" is common terminology, this actually reads better than "if (!inst->readPredicate())". - Steve On 2010-12-06 16:11:17, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/339/ > ----------------------------------------------------------- > > (Updated 2010-12-06 16:11:17) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ARM: Add support for moving predicated false dest operands from sources. > > > Diffs > ----- > > src/arch/arm/isa/insts/misc.isa 2b5fbdcbfb5d > src/arch/isa_parser.py 2b5fbdcbfb5d > src/cpu/o3/dyn_inst.hh 2b5fbdcbfb5d > src/cpu/o3/iew_impl.hh 2b5fbdcbfb5d > src/cpu/o3/lsq_unit_impl.hh 2b5fbdcbfb5d > > Diff: http://reviews.m5sim.org/r/339/diff > > > Testing > ------- > > > Thanks, > > Ali > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
