----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/367/#review608 -----------------------------------------------------------
Hi Nate, I have a couple questions: 1. Have you looked at the protocol trace output after your change? Does it look exactly like it did before? It seems that the output should be the same based on my brief inspection of your patch, but I would like to be sure about that. It may not be obvious, but there is a specific rational behind the format of the protocol trace and I want to make sure that stays the same. 2. With your patch applied, what happens if one hits an assert when running interactively? Previously, the process would abort allowing one to attach gdb and examine what is going on. I liked that feature and it would be great if we could maintain it. Could we port that feature to all of M5? - Brad On 2011-01-04 15:02:38, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/367/ > ----------------------------------------------------------- > > (Updated 2011-01-04 15:02:38) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ruby: get rid of ruby's Debug.hh > > Get rid of the Debug class > Get rid of ASSERT and use assert > Use DPRINTF for ProtocolTrace > > > Diffs > ----- > > configs/ruby/Ruby.py 7338bc628489 > src/mem/SConscript 7338bc628489 > src/mem/ruby/buffers/MessageBuffer.hh 7338bc628489 > src/mem/ruby/buffers/MessageBuffer.cc 7338bc628489 > src/mem/ruby/common/Debug.hh 7338bc628489 > src/mem/ruby/common/Debug.cc 7338bc628489 > src/mem/ruby/common/Debug.py 7338bc628489 > src/mem/ruby/common/Global.hh 7338bc628489 > src/mem/ruby/common/Global.cc 7338bc628489 > src/mem/ruby/common/SConscript 7338bc628489 > src/mem/ruby/common/Set.cc 7338bc628489 > src/mem/ruby/eventqueue/RubyEventQueue.cc 7338bc628489 > src/mem/ruby/filters/BulkBloomFilter.cc 7338bc628489 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 7338bc628489 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > 7338bc628489 > src/mem/ruby/network/garnet/fixed-pipeline/flit_d.hh 7338bc628489 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 7338bc628489 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc > 7338bc628489 > src/mem/ruby/network/garnet/flexible-pipeline/flit.hh 7338bc628489 > src/mem/ruby/network/simple/SimpleNetwork.cc 7338bc628489 > src/mem/ruby/network/simple/Throttle.cc 7338bc628489 > src/mem/ruby/network/simple/Topology.cc 7338bc628489 > src/mem/ruby/profiler/Profiler.hh 7338bc628489 > src/mem/ruby/profiler/Profiler.cc 7338bc628489 > src/mem/ruby/slicc_interface/RubySlicc_Util.hh 7338bc628489 > src/mem/ruby/storebuffer/storebuffer.cc 7338bc628489 > src/mem/ruby/system/RubySystem.py 7338bc628489 > src/mem/ruby/system/Sequencer.cc 7338bc628489 > src/mem/ruby/system/System.cc 7338bc628489 > src/mem/ruby/tester/DeterministicDriver.cc 7338bc628489 > src/mem/ruby/tester/RaceyDriver.cc 7338bc628489 > src/mem/ruby/tester/RaceyPseudoThread.cc 7338bc628489 > src/mem/ruby/tester/test_framework.cc 7338bc628489 > src/mem/slicc/symbols/StateMachine.py 7338bc628489 > src/mem/slicc/symbols/Type.py 7338bc628489 > > Diff: http://reviews.m5sim.org/r/367/diff > > > Testing > ------- > > This compiles and passes all of the quick regressions, but it would be nice > for a Ruby developer to take a look and see if I got rid of any useful > functionality. > > > Thanks, > > Nathan > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
