On Tue, Jan 4, 2011 at 10:09 PM, nathan binkert <n...@binkert.org> wrote:

> >> Neat idea, but you need to check "sys.stdout.isatty()" and conditionally
> >> add the color.  Then you're going to want a way to override that if
> you're
> >> piping through less :)  Seems like we could add a --color option to the
> >> SCons command line.
> >
> > It actually crossed my mind earlier today to use colorization to
> distinguish
> > the common prefix part of the source path from the source-specific part,
> as
> > a way of eliminating the ambiguity of how to form the target.
> >
> > The isatty check would take care of the less problem, though...
> Actually less -r allows you to take the control characters, so the
> --color would override the isatty() == false and output the control
> codes anyway.
>

Ah, got it, I misunderstood your comment.


> As a thought, TRANSFORM should probably take the action abbreviation
> (e.g. "CC") as a parameter if you're going to do the colorization.
>

I don't follow... do you think the filenames should be colorized differently
depending on the command?  Note that the TRANSFORM* functions don't get
called directly by the user so you can't add params anyway (unless there's a
mechanism I'm unaware of).


> This is all overkill, but is a nice feature imho.
>

True enough...

Steve
_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to