----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/419/#review703 -----------------------------------------------------------
SConstruct <http://reviews.m5sim.org/r/419/#comment948> What happens if this fails? src/sim/root.hh <http://reviews.m5sim.org/r/419/#comment949> I think that it'd be better if we just put the declaration of the Root SimObject here. The reason it wasn't was probably just because nobody ever needed it before. This along with some sort of function like "Root *root();" to get the actual root object would eliminate the need for all of these wrapper functions. (Which don't buy us anything as far as I can tell). src/sim/root.hh <http://reviews.m5sim.org/r/419/#comment950> brace on the same line as namespace. Steve just went through and fixed a zillion instances of the namespace. It should probably be in the style guide. src/sim/root.hh <http://reviews.m5sim.org/r/419/#comment951> should be: } // namespace TimeSync src/sim/root.cc <http://reviews.m5sim.org/r/419/#comment952> Perhaps you can use base/time.hh? (and update it to use timespec If not, this should be <ctime> src/sim/root.cc <http://reviews.m5sim.org/r/419/#comment953> Probably make this private (and _root). Then make a static accessor. I say this because we may have to add a lock around it in the future parallel version. src/sim/root.cc <http://reviews.m5sim.org/r/419/#comment957> Ok, I apologize for being overly anal, but local variables are not camelCase, but with_underscores. src/sim/root.cc <http://reviews.m5sim.org/r/419/#comment955> Here's an example of where I'd like a temporary var (no requirement or anything like that). I think this would mean the same thing: int64_t remainder = period() - nsDiff; if (remainder > 0 && remainder > _spinThreshold) src/sim/root.cc <http://reviews.m5sim.org/r/419/#comment956> you could use remainder here. src/sim/root.cc <http://reviews.m5sim.org/r/419/#comment954> If librt isn't available, will this work? Is there an alternative? - Nathan On 2011-01-10 07:44:05, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/419/ > ----------------------------------------------------------- > > (Updated 2011-01-10 07:44:05) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Time: Add a mechanism to prevent M5 from running faster than real time. > > M5 skips over any simulated time where it doesn't have any work to do. When > the simulation is active, the time skipped is short and the work done at any > point in time is relatively substantial. If the time between events is long > and/or the work to do at each event is small, it's possible for simulated time > to pass faster than real time. When running a benchmark that can be good > because it means the simulation will finish sooner in real time. When > interacting with the real world through, for instance, a serial terminal or > bridge to a real network, this can be a problem. Human or network response > time > could be greatly exagerated from the perspective of the simulation and make > simulated events happen "too soon" from an external perspective. > > This change adds the capability to force the simulation to run no faster than > real time. It does so by scheduling a periodic event that checks to see if > its simulated period is shorter than its real period. If it is, it stalls the > simulation until they're equal. This is called time syncing. > > A future change could add pseudo instructions which turn time syncing on and > off from within the simulation. That would allow time syncing to be used for > the interactive parts of a session but then turned off when running a > benchmark using the m5 utility program inside a script. Time syncing would > probably not happen anyway while running a benchmark because there would be > plenty of work for M5 to do, but the event overhead could be avoided. > > > Diffs > ----- > > SConstruct c06505ff551e > configs/example/fs.py c06505ff551e > src/sim/Root.py c06505ff551e > src/sim/SConscript c06505ff551e > src/sim/root.hh PRE-CREATION > src/sim/root.cc c06505ff551e > > Diff: http://reviews.m5sim.org/r/419/diff > > > Testing > ------- > > > Thanks, > > Gabe > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
