> On 2011-01-18 07:03:49, Ali Saidi wrote: > > src/sim/root.hh, line 93 > > <http://reviews.m5sim.org/r/419/diff/2/?file=9736#file9736line93> > > > > This seems large enough that it should just go in the cc file
Done > On 2011-01-18 07:03:49, Ali Saidi wrote: > > src/sim/root.cc, line 52 > > <http://reviews.m5sim.org/r/419/diff/2/?file=9737#file9737line52> > > > > What sleep is this calling? The one defined in time.hh for M5's custom Time class. > On 2011-01-18 07:03:49, Ali Saidi wrote: > > src/sim/root.hh, line 53 > > <http://reviews.m5sim.org/r/419/diff/2/?file=9736#file9736line53> > > > > I would like to see a detailed comment about how it works here. e.g. > > the second paragraph from your commit message. Done > On 2011-01-18 07:03:49, Ali Saidi wrote: > > src/sim/root.hh, line 51 > > <http://reviews.m5sim.org/r/419/diff/2/?file=9736#file9736line51> > > > > Doxygen comments are needed throughout Done > On 2011-01-18 07:03:49, Ali Saidi wrote: > > src/sim/root.hh, line 30 > > <http://reviews.m5sim.org/r/419/diff/2/?file=9736#file9736line30> > > > > @file Done - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/419/#review764 ----------------------------------------------------------- On 2011-01-18 16:49:14, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/419/ > ----------------------------------------------------------- > > (Updated 2011-01-18 16:49:14) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Time: Add a mechanism to prevent M5 from running faster than real time. > > M5 skips over any simulated time where it doesn't have any work to do. When > the simulation is active, the time skipped is short and the work done at any > point in time is relatively substantial. If the time between events is long > and/or the work to do at each event is small, it's possible for simulated time > to pass faster than real time. When running a benchmark that can be good > because it means the simulation will finish sooner in real time. When > interacting with the real world through, for instance, a serial terminal or > bridge to a real network, this can be a problem. Human or network response > time > could be greatly exagerated from the perspective of the simulation and make > simulated events happen "too soon" from an external perspective. > > This change adds the capability to force the simulation to run no faster than > real time. It does so by scheduling a periodic event that checks to see if > its simulated period is shorter than its real period. If it is, it stalls the > simulation until they're equal. This is called time syncing. > > A future change could add pseudo instructions which turn time syncing on and > off from within the simulation. That would allow time syncing to be used for > the interactive parts of a session but then turned off when running a > benchmark using the m5 utility program inside a script. Time syncing would > probably not happen anyway while running a benchmark because there would be > plenty of work for M5 to do, but the event overhead could be avoided. > > > Diffs > ----- > > configs/example/fs.py 4c0f7929ee33 > src/sim/Root.py 4c0f7929ee33 > src/sim/SConscript 4c0f7929ee33 > src/sim/root.hh PRE-CREATION > src/sim/root.cc 4c0f7929ee33 > > Diff: http://reviews.m5sim.org/r/419/diff > > > Testing > ------- > > > Thanks, > > Gabe > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
