----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/499/#review890 -----------------------------------------------------------
Just some comments on the code. configs/common/SysPaths.py <http://reviews.m5sim.org/r/499/#comment1255> you could do "from SysPaths import disks, binaries, boot" then you can do filepath = disk.find("imagename.img") configs/common/path.py <http://reviews.m5sim.org/r/499/#comment1253> Both types of paths are searched configs/common/path.py <http://reviews.m5sim.org/r/499/#comment1256> I did this for backwards compat, but __call__ should probably go and we should probably only have find, doesn't matter much though. configs/common/path.py <http://reviews.m5sim.org/r/499/#comment1254> This class encapsulates the normal concept of a "path" configs/common/path.py <http://reviews.m5sim.org/r/499/#comment1252> The idea of a subpath is that there is a fixed directory structure within the path and you want to find a file within that known subdirectory. The "system" directory is the Path and we use SubPath for binaries, disks, and boot scripts which are fixed subdirectories that will be searched for in the path. - Nathan On 2011-02-23 11:10:06, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/499/ > ----------------------------------------------------------- > > (Updated 2011-02-23 11:10:06) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > This is some really old code that I wrote to work on the path problem (I > didn't realize that I had never committed it.) Anyway, you may find this > interesting and as a possible way to augment your diff Gabe. (Feel free to > incorporate it). I'll put a few comments in reviewboard here (which should > probably just be in the code itself). > > One major thing that should happen if you choose to use this is that path.py > and maybe even SysPaths.py too should be in m5.util. > > > Diffs > ----- > > configs/common/SysPaths.py UNKNOWN > configs/common/path.py PRE-CREATION > > Diff: http://reviews.m5sim.org/r/499/diff > > > Testing > ------- > > > Thanks, > > Nathan > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
