I finally took the time to look at this diff. It looks like a viable approach to implementing the path searching part, but I'm not there yet. This change is to tidy up the existing code and to make the default path more standard. Subsequent changes will search for each file instead of just finding a system directory that exists at all, handle subpaths, be integrated into M5 instead of the configs, etc. Since changing this code has the potential to break a lot of things if it doesn't work or to be really annoying if it isn't thought through enough, I'm going try to be really careful and ease into it.
Gabe On 02/23/11 11:10, Nathan Binkert wrote: > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/499/ > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, > and Nathan Binkert. > By Nathan Binkert. > > > Description > > This is some really old code that I wrote to work on the path problem (I > didn't realize that I had never committed it.) Anyway, you may find this > interesting and as a possible way to augment your diff Gabe. (Feel free to > incorporate it). I'll put a few comments in reviewboard here (which should > probably just be in the code itself). > > One major thing that should happen if you choose to use this is that path.py > and maybe even SysPaths.py too should be in m5.util. > > > Diffs > > * configs/common/SysPaths.py (UNKNOWN) > * configs/common/path.py (PRE-CREATION) > > View Diff <http://reviews.m5sim.org/r/499/diff/> > > > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
