Tony, You'll want to do the description such that the 1st line is just the summary line and then any detailed explanation goes on the following lines.
So more like this on future patches/commits: "sim: Fixes Simulation.py to allow more than 1 core for standard switching. This patch moves the assignment of testsys.switch_cpus, testsys.switch_cpus_1, switch_cpu_list, and switch_cpu_list1 outside of the for loop so they are assigned only once, after switch_cpus and switch_cpus_1 are constructed." This is because when run the command "hg tip" it only gives you the one line, so we want that to be a compact summary line and then if someone does "hg tip -v" they can get any additional info on a changeset. On Fri, Mar 11, 2011 at 6:11 PM, Anthony Gutierrez <atgut...@umich.edu> wrote: > > >> On 2011-03-11 12:21:35, Steve Reinhardt wrote: >> > Can you comment on why the current code is broken in the commit message? >> > It's not immediately obvious to me. > > Updated description. > > > - Anthony > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/564/#review941 > ----------------------------------------------------------- > > > On 2011-03-11 15:09:54, Anthony Gutierrez wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.m5sim.org/r/564/ >> ----------------------------------------------------------- >> >> (Updated 2011-03-11 15:09:54) >> >> >> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and >> Nathan Binkert. >> >> >> Summary >> ------- >> >> sim: Fixes Simulation.py to allow more than 1 core for standard switching. >> This patch moves the assignment of testsys.switch_cpus, >> testsys.switch_cpus_1, switch_cpu_list, and switch_cpu_list1 outside of the >> for loop so they are assigned only once, after switch_cpus and switch_cpus_1 >> are constructed. >> >> >> Diffs >> ----- >> >> configs/common/Simulation.py 77aa0f94e7f2 >> >> Diff: http://reviews.m5sim.org/r/564/diff >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Anthony >> >> > > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev > -- - Korey _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
