> On 2011-03-23 08:55:14, Steve Reinhardt wrote: > > I was pretty confused until I realized that the reviewboard web interface > > doesn't highlight whitespace changes, so the significant part about the > > assignments moving outside the loop (which was a simple matter of changing > > their indent level) doesn't show up. > > > > It looks like those assignments never should have been inside the loop > > anyway.
One comment though: the additional explanation in the commit message should start on a separate line so that the first line of the message is just a summary. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/564/#review1006 ----------------------------------------------------------- On 2011-03-11 15:09:54, Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/564/ > ----------------------------------------------------------- > > (Updated 2011-03-11 15:09:54) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > sim: Fixes Simulation.py to allow more than 1 core for standard switching. > This patch moves the assignment of testsys.switch_cpus, > testsys.switch_cpus_1, switch_cpu_list, and switch_cpu_list1 outside of the > for loop so they are assigned only once, after switch_cpus and switch_cpus_1 > are constructed. > > > Diffs > ----- > > configs/common/Simulation.py 77aa0f94e7f2 > > Diff: http://reviews.m5sim.org/r/564/diff > > > Testing > ------- > > > Thanks, > > Anthony > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
