----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/552/#review1009 -----------------------------------------------------------
Hi Somayeh, I was hoping this would be the final review, but I'm concerned that the current version has a memory leak (see below). Please correct me if I'm wrong, but right now it doesn't look like you delete Flush packets. Also there are a few other minor fixes you should make. Finally, please make sure you follow the convention for commit messages. src/mem/protocol/MOESI_hammer-cache.sm <http://reviews.m5sim.org/r/552/#comment1373> Don't add random white space. Please remove this line. src/mem/ruby/system/Sequencer.cc <http://reviews.m5sim.org/r/552/#comment1374> I don't think you need to separately handle Flush request. I believe the current implmementation of handleLlsc should always return true for Flush requests. Please remove this change. src/mem/ruby/system/Sequencer.cc <http://reviews.m5sim.org/r/552/#comment1376> I thought we concluded that Flush requests can callback the RubyPort? As long as needsResponse is set to false, the cpu should never see the packet which is what we want. Right now, I think you have a memory leak because the Flush packets are never deleted. Please correct me if I'm missing something. src/mem/ruby/system/Sequencer.cc <http://reviews.m5sim.org/r/552/#comment1375> Please remove the random white space. - Brad On 2011-03-23 22:28:01, Somayeh Sardashti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/552/ > ----------------------------------------------------------- > > (Updated 2011-03-23 22:28:01) > > > Review request for Default and Brad Beckmann. > > > Summary > ------- > > my initial implementation of cache flushing > > > Diffs > ----- > > configs/example/ruby_random_test.py baf4b5f6782e > src/cpu/testers/rubytest/Check.hh baf4b5f6782e > src/cpu/testers/rubytest/Check.cc baf4b5f6782e > src/cpu/testers/rubytest/RubyTester.hh baf4b5f6782e > src/cpu/testers/rubytest/RubyTester.cc baf4b5f6782e > src/cpu/testers/rubytest/RubyTester.py baf4b5f6782e > src/mem/packet.hh baf4b5f6782e > src/mem/packet.cc baf4b5f6782e > src/mem/protocol/MOESI_hammer-cache.sm baf4b5f6782e > src/mem/protocol/MOESI_hammer-dir.sm baf4b5f6782e > src/mem/protocol/MOESI_hammer-msg.sm baf4b5f6782e > src/mem/protocol/RubySlicc_Exports.sm baf4b5f6782e > src/mem/ruby/slicc_interface/RubyRequest.hh baf4b5f6782e > src/mem/ruby/slicc_interface/RubyRequest.cc baf4b5f6782e > src/mem/ruby/system/DMASequencer.cc baf4b5f6782e > src/mem/ruby/system/RubyPort.cc baf4b5f6782e > src/mem/ruby/system/Sequencer.cc baf4b5f6782e > > Diff: http://reviews.m5sim.org/r/552/diff > > > Testing > ------- > > This implementation has passed 10,000,000 ruby test cases, and the > MOESI_hammer regression tests. > > > Thanks, > > Somayeh > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
