----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/552/#review1013 -----------------------------------------------------------
Ship it! Hi Somayeh, Other than a couple minor comment updates (see below), this looks done to me. Congratulations! Make sure to run the regression tester and ask Arka or Nilay for help checking it in. src/mem/ruby/system/RubyPort.cc <http://reviews.m5sim.org/r/552/#comment1383> Please update this comment. Flushes also don't access physical memory. src/mem/ruby/system/RubyPort.cc <http://reviews.m5sim.org/r/552/#comment1382> please add a comment explaining what is going on here. - Brad On 2011-03-24 17:17:59, Somayeh Sardashti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/552/ > ----------------------------------------------------------- > > (Updated 2011-03-24 17:17:59) > > > Review request for Default and Brad Beckmann. > > > Summary > ------- > > my initial implementation of cache flushing > > > Diffs > ----- > > configs/example/ruby_random_test.py baf4b5f6782e > src/cpu/testers/rubytest/Check.hh baf4b5f6782e > src/cpu/testers/rubytest/Check.cc baf4b5f6782e > src/cpu/testers/rubytest/RubyTester.hh baf4b5f6782e > src/cpu/testers/rubytest/RubyTester.cc baf4b5f6782e > src/cpu/testers/rubytest/RubyTester.py baf4b5f6782e > src/mem/packet.hh baf4b5f6782e > src/mem/packet.cc baf4b5f6782e > src/mem/protocol/MOESI_hammer-cache.sm baf4b5f6782e > src/mem/protocol/MOESI_hammer-dir.sm baf4b5f6782e > src/mem/protocol/MOESI_hammer-msg.sm baf4b5f6782e > src/mem/protocol/RubySlicc_Exports.sm baf4b5f6782e > src/mem/ruby/slicc_interface/RubyRequest.hh baf4b5f6782e > src/mem/ruby/slicc_interface/RubyRequest.cc baf4b5f6782e > src/mem/ruby/system/DMASequencer.cc baf4b5f6782e > src/mem/ruby/system/RubyPort.cc baf4b5f6782e > src/mem/ruby/system/Sequencer.cc baf4b5f6782e > > Diff: http://reviews.m5sim.org/r/552/diff > > > Testing > ------- > > This implementation has passed 10,000,000 ruby test cases, and the > MOESI_hammer regression tests. > > > Thanks, > > Somayeh > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
