----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/606/#review1017 -----------------------------------------------------------
src/SConscript <http://reviews.m5sim.org/r/606/#comment1386> I would have thought that only the first part of the if were necessary. Why are you checking if extra_dir is in BUILDROOT? Please move the comment to the next line as we have a rule limiting lines to 80 characters. - Nathan On 2011-03-25 12:47:05, brad danofsky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/606/ > ----------------------------------------------------------- > > (Updated 2011-03-25 12:47:05) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Add the ability to have the build directory live under the EXTRAS directory > > > Diffs > ----- > > src/SConscript 89cd8302abd3 > > Diff: http://reviews.m5sim.org/r/606/diff > > > Testing > ------- > > I ran the standard m5 regression > > > Thanks, > > brad > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
