I gave Brad some feedback outside of the system and asked him to drop the second part of the patch since it was unrelated and (we believe after further discussion) unnecessary. So that part wasn't accidental.
Steve On Fri, Mar 25, 2011 at 6:54 PM, Gabe Black <gbl...@eecs.umich.edu> wrote: > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/606/ > > It looks like you accidentally dropped one of the changes between the first > and second versions of the diff. It would be a good idea to post those > separately anyway so we can discuss them separately. Don't worry about having > the extra review in the system even for these relatively short patches. Also, > I'm assuming since this is really two patches that your commit messages > would/will be different, but the rule is that the first line is a tag with an > ":" at the end and then a one line summary. Something like > > Foo: Add bar to our foo support. > > blah blah, all about the change, blah blah > > > - Gabe > > On March 25th, 2011, 12:47 p.m., brad danofsky wrote: > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > By brad danofsky. > > *Updated 2011-03-25 12:47:05* > Description > > Add the ability to have the build directory live under the EXTRAS directory > > Testing > > I ran the standard m5 regression > > Diffs > > - src/SConscript (89cd8302abd3) > > View Diff <http://reviews.m5sim.org/r/606/diff/> > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
