----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/610/#review1025 -----------------------------------------------------------
Why do you need this functionality? Why isn't "::" sufficient? If it's because some other piece of software is expecting something else, I'd say either write a script that munges these stats into a more acceptable format, or adjust the other software. I'm not an expert on our stats stuff by any stretch, but I'd hate to see extra otherwise unnecessary functionality be added to deal with a point issue that only affects a few people. src/base/statistics.hh <http://reviews.m5sim.org/r/610/#comment1393> The bracket should be on the next line for functions, and should have a space before it if it were to go on that line. src/base/statistics.hh <http://reviews.m5sim.org/r/610/#comment1394> This line is too long. You should spread it out like a normal function. - Gabe On 2011-03-29 07:13:30, brad danofsky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/610/ > ----------------------------------------------------------- > > (Updated 2011-03-29 07:13:30) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Add the user settable seperator string for arrayed stats, default is standard > :: > > I followed the flow for setting the description, name, etc. adding the > ability to set the seperator string used > between the array element and the name for vectors, vector2d, etc. > One difference, that might be objectionable, is I made the stored string > static. > > > Diffs > ----- > > src/base/statistics.hh d8587c913ccf > src/base/statistics.cc d8587c913ccf > src/base/stats/info.hh d8587c913ccf > src/base/stats/text.cc d8587c913ccf > > Diff: http://reviews.m5sim.org/r/610/diff > > > Testing > ------- > > standard full regression > > > Thanks, > > brad > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
