> On 2011-03-29 09:05:00, Gabe Black wrote: > > src/base/statistics.hh, line 265 > > <http://reviews.m5sim.org/r/610/diff/1/?file=11256#file11256line265> > > > > The bracket should be on the next line for functions, and should have a > > space before it if it were to go on that line. > > brad danofsky wrote: > do you have an emacs mode hook for setting up your general style forms?
I use vim so I don't use one myself, but util/emacs/m5-c-style.el looks like what you want. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/610/#review1025 ----------------------------------------------------------- On 2011-03-29 09:06:43, brad danofsky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/610/ > ----------------------------------------------------------- > > (Updated 2011-03-29 09:06:43) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Add the user settable separator string for arrayed stats, default is standard > :: > > I followed the flow for setting the description, name, etc. adding the > ability to set the seperator string used > between the array element and the name for vectors, vector2d, etc. > One difference, that might be objectionable, is I made the stored string > static. > > > Diffs > ----- > > src/base/statistics.hh d8587c913ccf > src/base/statistics.cc d8587c913ccf > src/base/stats/info.hh d8587c913ccf > src/base/stats/text.cc d8587c913ccf > > Diff: http://reviews.m5sim.org/r/610/diff > > > Testing > ------- > > standard full regression > > > Thanks, > > brad > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
