----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/614/#review1036 -----------------------------------------------------------
One thing that should change is that isBranch passes through the ISA description code and fills in the template with the same value every time. If it's always the same (or could be harmlessly) then it should just be in the template. Note that this is different from the predicate test because it doesn't use any operands which -do- have to pass through the parser, just a local variable and a constant which have no special requirements. The other rasPop component may be the same, but it was less obvious where all that was being used. - Gabe On 2011-03-30 09:02:35, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/614/ > ----------------------------------------------------------- > > (Updated 2011-03-30 09:02:35) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ARM: Tag appropriate instructions as IsReturn > > > Diffs > ----- > > src/arch/arm/isa/insts/branch.isa d54b7775a6b0 > src/arch/arm/isa/insts/data.isa d54b7775a6b0 > src/arch/arm/isa/insts/ldr.isa d54b7775a6b0 > src/arch/arm/isa/insts/mem.isa d54b7775a6b0 > src/arch/arm/isa/templates/branch.isa d54b7775a6b0 > src/arch/arm/isa/templates/mem.isa d54b7775a6b0 > src/arch/arm/isa/templates/pred.isa d54b7775a6b0 > > Diff: http://reviews.m5sim.org/r/614/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
