> On 2011-03-30 09:22:13, Gabe Black wrote: > > One thing that should change is that isBranch passes through the ISA > > description code and fills in the template with the same value every time. > > If it's always the same (or could be harmlessly) then it should just be in > > the template. Note that this is different from the predicate test because > > it doesn't use any operands which -do- have to pass through the parser, > > just a local variable and a constant which have no special requirements. > > The other rasPop component may be the same, but it was less obvious where > > all that was being used. > > Ali Saidi wrote: > I don't get what you mean. isBranch depends on the instruction and the > destination register. I don't see any benefit from creating a new template > which would be a duplicate of the non-isbranch case with this the branch case > added. Seems like that is way messier.
There's only one template that uses isBranch, right? And it's always either "0" or "dest == INTREG_PC", right? So why not just hard code it to "dest == INTREG_PC"? It's at construction time which is less important performance wise, and if you're writing to the PC it's a branch. I don't think you should make a new template, but if you can pull stuff out of the ISA desc with all else being equal then that would be a good idea. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/614/#review1036 ----------------------------------------------------------- On 2011-03-30 09:02:35, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/614/ > ----------------------------------------------------------- > > (Updated 2011-03-30 09:02:35) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ARM: Tag appropriate instructions as IsReturn > > > Diffs > ----- > > src/arch/arm/isa/insts/branch.isa d54b7775a6b0 > src/arch/arm/isa/insts/data.isa d54b7775a6b0 > src/arch/arm/isa/insts/ldr.isa d54b7775a6b0 > src/arch/arm/isa/insts/mem.isa d54b7775a6b0 > src/arch/arm/isa/templates/branch.isa d54b7775a6b0 > src/arch/arm/isa/templates/mem.isa d54b7775a6b0 > src/arch/arm/isa/templates/pred.isa d54b7775a6b0 > > Diff: http://reviews.m5sim.org/r/614/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
