> On 2011-03-30 09:08:07, Gabe Black wrote: > > src/cpu/base_dyn_inst.hh, line 246 > > <http://reviews.m5sim.org/r/520/diff/2/?file=11291#file11291line246> > > > > This comment is inaccurate. It's really the largest address that's part > > of the request, which is the effective address plus the size and then minus > > one. Also, this feels like a temporary variable promoted to too large of a > > scope and/or permanence. "size" seems like it would be more generally > > useful, it would be more immediately obvious what it is, and you can go > > from one to the other easily like you are elsewhere in this change.
I'll change it to size. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/520/#review1034 ----------------------------------------------------------- On 2011-03-30 08:41:48, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/520/ > ----------------------------------------------------------- > > (Updated 2011-03-30 08:41:48) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > O3: Tighten memory order violation checking to 16 bytes. > > The comment in the code suggests that the checking granularity should be 16 > bytes, however in reality the shift by 8 is 256 bytes which seems much > larger than required. > > > Diffs > ----- > > src/cpu/base_dyn_inst.hh d54b7775a6b0 > src/cpu/o3/O3CPU.py d54b7775a6b0 > src/cpu/o3/lsq_unit.hh d54b7775a6b0 > src/cpu/o3/lsq_unit_impl.hh d54b7775a6b0 > > Diff: http://reviews.m5sim.org/r/520/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
