----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/720/#review1265 -----------------------------------------------------------
src/python/m5/SimObject.py <http://reviews.m5sim.org/r/720/#comment1742> Does this do what you want? It doesn't seem like it would recurse down the tree and find all nodes that match (or does it?) src/python/m5/params.py <http://reviews.m5sim.org/r/720/#comment1743> what exactly is this doing? Also, what happens if val is of length 2 and the first element is a list or tuple? Seems like an error condition or you're doing something wrong. src/python/m5/proxy.py <http://reviews.m5sim.org/r/720/#comment1744> Seems like Mr Doxygen should be documenting this file a bit better :) Also, what does Parent.all do? It'd be nice if you described Self.all and Parent.all in this file. - Nathan On 2011-05-26 19:17:18, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/720/ > ----------------------------------------------------------- > > (Updated 2011-05-26 19:17:18) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Config: Add support for a Self.all proxy object > > > Diffs > ----- > > src/python/m5/SimObject.py 3f37cc5d25bc > src/python/m5/params.py 3f37cc5d25bc > src/python/m5/proxy.py 3f37cc5d25bc > src/sim/System.py 3f37cc5d25bc > > Diff: http://reviews.m5sim.org/r/720/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list gem5-dev@m5sim.org http://m5sim.org/mailman/listinfo/gem5-dev
