> On 2011-05-28 17:22:15, Steve Reinhardt wrote: > > src/sim/System.py, line 47 > > <http://reviews.m5sim.org/r/720/diff/1/?file=12676#file12676line47> > > > > It seems odd that Parent.any here will generate an error if there are > > multiple matches, but Self.all only is necessary if there are multiple > > matches. I think the reason it's not a problem is that this Parent.any > > proxy on physmem is never used. Should we get rid of it?
You mean we set it to something and we should make it have no default? Another option would be to change the way this works a bit. Just use the memories above. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/720/#review1272 ----------------------------------------------------------- On 2011-05-26 19:17:18, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/720/ > ----------------------------------------------------------- > > (Updated 2011-05-26 19:17:18) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Config: Add support for a Self.all proxy object > > > Diffs > ----- > > src/python/m5/SimObject.py 3f37cc5d25bc > src/python/m5/params.py 3f37cc5d25bc > src/python/m5/proxy.py 3f37cc5d25bc > src/sim/System.py 3f37cc5d25bc > > Diff: http://reviews.m5sim.org/r/720/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list gem5-dev@m5sim.org http://m5sim.org/mailman/listinfo/gem5-dev
